Add feature that can disable traffic generator metrics. #807
Conversation
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
| if metricsBlacklist == nil { | ||
| metricsBlacklist = []string{} | ||
| } | ||
| if metricsFuzzyBlacklist == nil { | ||
| metricsFuzzyBlacklist = []string{} | ||
| } |
There was a problem hiding this comment.
nit: I don't think these are needed
| @@ -106,6 +106,9 @@ func NewConfig(ctx *cli.Context) (*Config, error) { | |||
| EigenDAServiceManager: retrieverConfig.EigenDAServiceManagerAddr, | |||
| SignerPrivateKey: ctx.String(SignerPrivateKeyFlag.Name), | |||
| CustomQuorums: customQuorumsUint8, | |||
|
|
|||
| MetricsBlacklist: ctx.StringSlice(MetricsBlacklistFlag.Name), | |||
There was a problem hiding this comment.
why do we need both flags?
could we just use MetricsFuzzyBlacklist? not sure what use cases there are where we want exact matching vs. fuzzy matching (fuzzy matching can cover all use cases we need for exact matching)
There was a problem hiding this comment.
Fuzzy matching is needed to handle metric labels that contain DA node IDs. Exact matching is needed to disable metrics where one metric is a substring of another. For example, there are two metrics labeled read and read_success. Without exact matching, we couldn't disable the read metric without also disabling the read_success metric.
The only straight forward way to avoid having two lists would be to interpret each entry as a regex. In your opinion, would you prefer to have a single list of regex blacklist arguments, or the current pattern?
There was a problem hiding this comment.
I see. That makes sense. I think the current pattern is simpler in that case
| @@ -14,14 +14,19 @@ type CountMetric interface { | |||
| type countMetric struct { | |||
| metrics *metrics | |||
| description string | |||
| // If true, the metric is disabled and should behave as a no-op. | |||
There was a problem hiding this comment.
nit: disabled specifies whether the metrics should behave as a no-op or something like that
There was a problem hiding this comment.
wording updated
Signed-off-by: Cody Littley <[email protected]>
Why are these changes needed?
We may not want all metrics to be enabled for the traffic generator.
Checks